Re: Converting contrib SQL functions to new style

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: Converting contrib SQL functions to new style
Date: 2025-01-08 02:32:00
Message-ID: Z33joDRv_r_gJSd9@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 06, 2025 at 11:04:28AM -0800, Noah Misch wrote:
> Per postgr.es/m/3489827.1618411777@sss.pgh.pa.us and
> postgr.es/m/1471865.1734212070@sss.pgh.pa.us one requirement for migrating to
> SQL-standard function bodies is removing these inexact-match function and
> operator calls. Here, one could either write pg_catalog.generate_series or
> make the argument types match exactly.

Thanks for the report.

Tom has used casts for xml2 in 667368fd26de, and also combined some
pg_catalog for schema qualifications in citext for example. In this
case forcing the data types seems more elegant to me.

What do you think about the attached?
--
Michael

Attachment Content-Type Size
freespace-bug.patch text/x-diff 644 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2025-01-08 02:52:33 Re: Converting contrib SQL functions to new style
Previous Message Sami Imseih 2025-01-08 02:14:25 Re: Psql meta-command conninfo+