Re: Memory leak in pg_logical_slot_{get,peek}_changes

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Memory leak in pg_logical_slot_{get,peek}_changes
Date: 2025-01-07 23:49:48
Message-ID: Z329nGl6E8WG_aTm@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 30, 2024 at 10:31:20PM +0530, vignesh C wrote:
> The attached v3 version has the changes for the same. I have verified
> the patch in PG14 and PG13 by attaching to the debugger and calling
> "call MemoryContextStats(CacheMemoryContext)" to see there are no
> leaks.

Sorry for the delay here, I have come back into the business.

I have tuned a bit the comment block on top of the declaration of the
two contexts, fixed a comment in maybe_send_schema() that was now
inexact, and applied that down to v13 and v14.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-01-07 23:54:40 Re: per backend I/O statistics
Previous Message Michael Paquier 2025-01-07 23:47:05 Re: Switching XLog source from archive to streaming when primary available