Re: Small patch to use pqMsg_Query instead of `Q`

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
Cc: Dave Cramer <davecramer(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Small patch to use pqMsg_Query instead of `Q`
Date: 2025-01-07 16:58:40
Message-ID: Z31dQOPUZNBFg2JU@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 07, 2025 at 01:25:31PM -0300, Fabrízio de Royes Mello wrote:
> On Tue, Jan 7, 2025 at 12:42 PM Dave Cramer <davecramer(at)gmail(dot)com> wrote:
>> Previously we have replaced the use of literal characters with pqMsg*. Not
>> sure how this one escaped detection.

It's not the first to escape detection, and it probably won't be the
last...

> LGTM... looks like a leftover from f4b54e1e.

I'll commit this shortly. I'd argue this falls into the category of
"low-risk fixes," so I'll also plan on back-patching it to v17 (where
protocol.h was first added).

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2025-01-07 17:15:17 Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section
Previous Message Andres Freund 2025-01-07 16:32:10 Re: AIO v2.2