| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Pass ParseState as down to utility functions. |
| Date: | 2024-12-25 09:28:52 |
| Message-ID: | Z2vQVPTjIlJGNrQb@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 16, 2024 at 05:25:45PM +0800, jian he wrote:
> i've split into 3 patches, feel free to merge them in any way.
> v12-0001: add error position for ATPrepAlterColumnType.
For this one, why don't you do the same for undefined columns and
USING with generated columns at least? This looks half-baked.
> v12-0002: add error position for these 3 functions:
> transformColumnDefinition, transformAlterTableStmt, transformTableConstraint.
ERROR: column "c" of relation "itest4" does not exist
+LINE 1: ALTER TABLE itest4 ALTER COLUMN c ADD GENERATED ALWAYS AS ID...
+ ^
This one is kind of confusing? The part that matters for the error is
the column that does not exist, not the ADD GENERATED.
ERROR: conflicting NO INHERIT declarations for not-null constraints on column "a"
+LINE 1: ..._tbl_fail (a int generated by default as identity not null n...
+ ^
This one also, is kind of hard-ish to act on..
> v12-0003: add error position for these 2 functions:
> DefineType, transformOfType
This one has been applied as of 0f23dedc9176.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2024-12-25 09:36:54 | Re: ERROR: corrupt MVNDistinct entry |
| Previous Message | Heikki Linnakangas | 2024-12-25 09:27:38 | Re: Recovering from detoast-related catcache invalidations |