| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: per backend I/O statistics |
| Date: | 2024-12-19 06:12:04 |
| Message-ID: | Z2O5NHs60I4+zTyj@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Dec 19, 2024 at 01:21:54PM +0900, Michael Paquier wrote:
>
> While doing more tests with backends exiting concurrently with their
> stats scanned, I have detected one path in pg_stat_get_backend_io()
> after calling pgstat_get_beentry_by_proc_number() where we should also
> check that it does not return NULL, or we would crash on a pointer
> dereference when reading the backend type.
>
> Fixed that,
Oh right, indeed all the others pgstat_get_beentry_by_proc_number() callers are
checking for a NULL returned value.
> bumped the two version counters, and done.
Thanks!
I think I'll start a dedicated thread to discuss the stats_fetch_consistency/'snapshot'
point (will be easier to follow than resuming the discussion in this thread).
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2024-12-19 06:19:50 | Re: Row pattern recognition |
| Previous Message | Bertrand Drouvot | 2024-12-19 05:49:51 | Re: Removing the pgstat_flush_io() call from the walwriter |