| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: per backend I/O statistics |
| Date: | 2024-12-12 04:11:09 |
| Message-ID: | Z1piXTC8X0uu-MSz@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 27, 2024 at 04:00:14PM +0000, Bertrand Drouvot wrote:
> I'd vote to just keep the pgstat_create_backend_stat() call in pgstat_beinit().
>
> That said, we probably should document that init_backend_cb() should not call
> pgstat_get_entry_ref(), but that's probably worth another thread.
Hmm, yeah. I have considered this point and your approach does not
seem that bad to me after thinking much more about it, and you are
putting the call in pgstat_beinit(), which is about initializing the
stats for the backend. So I'm OK with what the patch does here in
terms of the location where pgstat_create_backend_stat() is called.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-12-12 04:12:35 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | vignesh C | 2024-12-12 04:04:19 | Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility. |