Re: Changing the state of data checksums in a running cluster

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tomas Vondra <tomas(at)vondra(dot)me>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Changing the state of data checksums in a running cluster
Date: 2024-12-11 04:47:08
Message-ID: Z1kZTF12ozJrmzYy@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 26, 2024 at 11:07:12PM +0100, Tomas Vondra wrote:
> I spent a bit more time doing some testing on the last version of the
> patch from [1]. And I ran into this assert in PostmasterStateMachine()
> when stopping the cluster:
>
> /* All types should be included in targetMask or remainMask */
> Assert((remainMask.mask | targetMask.mask) == BTYPE_MASK_ALL.mask);
>
> At first I was puzzled as this happens on every shutdown, but that's
> because these checks were introduced by a78af0427015 a week ago. So it's
> more a matter of rebasing.

Looks like the CI is not really happy about this point.. (Please make
sure to refresh the patch status after a review.)
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shlok Kyal 2024-12-11 04:50:49 Re: Subscription sometimes loses txns after initial table sync
Previous Message Michael Paquier 2024-12-11 04:38:31 Re: attndims, typndims still not enforced, but make the value within a sane threshold