Fix comments related to pending statistics

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Fix comments related to pending statistics
Date: 2024-12-10 14:16:14
Message-ID: Z1hNLvcPgVLPxCoc@ip-10-97-1-34.eu-west-3.compute.internal
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

while working on [1], I came across 2 comments in pgstat.h that I think are
not correct.

1. One linked to PgStat_TableCounts pending stats, mentioning the use of
memcmp() against zeroes to detect whether there are any stats updates to apply.

This is not true anymore as of 07e9e28b56.

2. One linked to PgStat_FunctionCounts pending stats, mentioning the use of
memcmp() against zeroes to detect whether there are any pending stats: I think
it has never been the case.

Please find attached a patch to fix those comments.

[1]: https://www.postgresql.org/message-id/flat/ZlGYokUIlERemvpB%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v1-0001-Fix-comments-related-to-pending-statistics.patch text/x-diff 1.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey M. Borodin 2024-12-10 14:17:55 Re: Fix bank selection logic in SLRU
Previous Message Jim Jones 2024-12-10 14:14:41 Re: XMLDocument (SQL/XML X030)