Re: attndims, typndims still not enforced, but make the value within a sane threshold

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: attndims, typndims still not enforced, but make the value within a sane threshold
Date: 2024-12-05 23:24:40
Message-ID: Z1I2OL0-CUe9P_Uy@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 5, 2024 at 12:03:30PM -0500, Bruce Momjian wrote:
> On Thu, Dec 5, 2024 at 12:00:30PM -0500, Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > On Thu, Dec 5, 2024 at 11:33:22AM -0500, Tom Lane wrote:
> > >> I don't think we can do this as presented. Maybe we could do
> > >> something like constrain the stored value to be only 0 or 1,
> > >> but how much does that improve matters?
> >
> > > Well, then the question becomes will we retain useless system columns
> > > forever?
> >
> > If the choice is "not break PHP" versus "get rid of a vestigial column",
> > I know which one is the saner choice. There might be things that are
> > worth breaking PHP for, but this isn't one.
>
> I guess I just don't want to get into a situation where we have so many
> useless backward-compatible system columns it is distracting.

How about if we set attndims & typndims to zero in PG 18, and mention
that these fields are deprecated in the release notes. Then, in a few
years, we can remove the columns since interfaces hopefully would have
removed the useless references to the columns.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-12-05 23:34:31 Re: attndims, typndims still not enforced, but make the value within a sane threshold
Previous Message Nathan Bossart 2024-12-05 22:50:34 Re: Remove dependence on integer wrapping