Re: More CppAsString2() in psql's describe.c

On Thu, Nov 28, 2024 at 10:40:35AM +0100, Daniel Gustafsson wrote:
> LGTM, I didn't scan for omissions but the ones in the patch look right to me.
> I sort of wish we had a shorter macro as CppAsString2() get's pretty verbose
> when used frequently like this.

Thanks for the reviews, applied what I had. I've managed to miss a
c.contype = 'n' in describeOneTableDetails(), actually, so I've fixed
it while on it.

Here are some notes about the state of things in describe.c:
- RELKIND_SPECIAL does not exist anymore, see listTables().
- pg_depend.deptype, that cannot be changed currently as
DependencyType is in dependency.h.
- pol.polcmd wants some ACLs now in acl.h.
- tgenabled has some hardcoded values now in trigger.h.
- Event triggers with evtenabled has values in trigger.h
(TRIGGER_FIRES_ON_ORIGIN).
- attcompression has two values for lz4 and pglz.
- substream, where LOGICALREP_STREAM_ON & friends should be added to
pg_subscription_d.h to allow the move. Perhaps we should just do that
for the subscription case. That's worth a patch of its own as it
changes pg_subscription_d.h. I'll spawn a new thread about that.
--
Michael