Re: More CppAsString2() in psql's describe.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: More CppAsString2() in psql's describe.c
Date: 2024-11-28 06:34:55
Message-ID: Z0gPD0CH4WiaIvu5@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 22, 2024 at 09:49:10AM +0900, Michael Paquier wrote:
> Note that there were a couple of value checks not part of the queries
> that relied on values from the catalogs for some relpersistences and
> replidents. I've fixed them while on it.
>
> Thoughts or comments are welcome.

So, this one has been sitting in the CF for a couple of weeks now.
I've looked at it again and the queries are written the same. There
was one inconsistency with the ordering of the headers and one
indentation issue with a query for extended stats.

Any objections against applying it? This is the last area of the code
where we rely on such hardcoded values rather than CppAsString2().
Note also the pg_am.h inclusion which is incorrect.
--
Michael

Attachment Content-Type Size
v2-0001-psql-Sprinkle-more-CppAsString2-in-describe.c.patch text/x-diff 19.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-11-28 06:43:04 Re: Add Pipelining support in psql
Previous Message wenhui qiu 2024-11-28 06:25:23 Re: Auto Vacuum optimisation