| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Memory leak in WAL sender with pgoutput (v10~) |
| Date: | 2024-12-04 06:21:55 |
| Message-ID: | Z0_1A1WVifOGVLls@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 04, 2024 at 11:05:43AM +0530, Amit Kapila wrote:
> On Wed, Dec 4, 2024 at 7:39 AM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>> It appears there is an additional memory leak caused by allocating publication
>> names within the CacheMemoryContext, as noted in [1]. And it can also be fixed by
>> creating a separate memctx for publication names under the logical decoding
>> context. I think the approach makes sense since the lifespan of publication
>> names should ideally align with that of the logical decoding context.
>
> Yeah, I don't think we can go with the proposed patch for the local
> memory context as it is.
Ah, indeed. I was missing your point. Would any of you like to write
a patch to achieve that?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2024-12-04 06:40:37 | Re: Proposal for Updating CRC32C with AVX-512 Algorithm. |
| Previous Message | Tom Lane | 2024-12-04 06:19:32 | Re: Cannot find a working 64-bit integer type on Illumos |