Re: Use __attribute__((target(sse4.2))) for SSE42 CRC32C

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: "Devulapalli, Raghuveer" <raghuveer(dot)devulapalli(at)intel(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Shankaran, Akash" <akash(dot)shankaran(at)intel(dot)com>
Subject: Re: Use __attribute__((target(sse4.2))) for SSE42 CRC32C
Date: 2024-11-22 20:42:04
Message-ID: Z0DsnGtosDduShSP@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 21, 2024 at 11:07:59PM +0000, Devulapalli, Raghuveer wrote:
> Thanks for the review! We can actually leverage meson's built in option
> to check for a macro: cc.get_define('__SSE4_2__') != ''. This should keep
> the logic consistent across configure and meson.

I think we should still use the test program even when __SSE4_2__ is
defined, but we can use that macro to determine whether to use a runtime
check. I think that would keep autoconf and meson consistent.

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-11-22 20:44:19 Re: Make COPY format extendable: Extract COPY TO format implementations
Previous Message Nathan Bossart 2024-11-22 19:21:53 Re: Allow non-superuser to cancel superuser tasks.