| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Better error message when --single is not the first arg to postgres executable |
| Date: | 2024-12-03 17:05:34 |
| Message-ID: | Z086Xnk1e1_2F8ra@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here's what I have staged for commit. I didn't like how v4 added the ERROR
to ParseLongOption(), so in v5 I've moved it to the callers of
ParseLongOption(), which is where the existing option validation lives.
This results in a bit of code duplication, but IMHO that's better than
adding nonobvious behavior to ParseLongOption().
Barring additional feedback or cfbot failures, I'm planning on committing
this shortly.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Provide-a-better-error-message-for-misplaced-subp.patch | text/plain | 8.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2024-12-03 17:22:43 | Re: Better error message when --single is not the first arg to postgres executable |
| Previous Message | Alvaro Herrera | 2024-12-03 17:04:49 | Re: crash with synchronized_standby_slots |