| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Memory leak in WAL sender with pgoutput (v10~) |
| Date: | 2024-12-03 06:46:50 |
| Message-ID: | Z06pWkQAgQvKYqwG@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 02, 2024 at 03:29:56PM +0530, Amit Kapila wrote:
> We can look at it from a different angle which is that the
> FreePublication(s) relies on how the knowledge of Publication
> structure is built. So, it doesn't look weird if we think from that
> angle.
OK, I can live with that on all the stable branches with an extra
list free rather than a deep list free.
I agree that the memory handling of this whole area needs some rework
to make such leaks harder to introduce in the WAL sender. Still,
let's first solve the problem at hand :)
So how about the attached that introduces a FreePublication() matching
with GetPublication(), used to do the cleanup? Feel free to comment.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-memory-leak-in-pgoutput-with-publication-list.patch | text/x-diff | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2024-12-03 06:56:48 | Re: Memory leak in WAL sender with pgoutput (v10~) |
| Previous Message | jian he | 2024-12-03 06:43:00 | Re: speedup ALTER TABLE ADD CHECK CONSTRAINT. |