| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | "Devulapalli, Raghuveer" <raghuveer(dot)devulapalli(at)intel(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Shankaran, Akash" <akash(dot)shankaran(at)intel(dot)com> |
| Subject: | Re: Proposal for Updating CRC32C with AVX-512 Algorithm. |
| Date: | 2024-12-03 23:02:39 |
| Message-ID: | Z0-OD2P_Sw9T7dQ-@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 03, 2024 at 03:46:16PM +0000, Devulapalli, Raghuveer wrote:
>> Raghuveer, would you mind rebasing this patch set now that the SSE4.2 patch is
>> committed?
>
> Rebased to master branch.
Thanks! cfbot is showing a couple of errors [0] [1] [2]. 32-bit Linux is
failing to compile with the 64-bit intrinsics. I think it'd be fine to
limi this optimization to 64-bit builds unless the code can be easily fixed
to work for both. The macOS build seems to be trying to include the x86
headers, which is producing many errors. We'll need to make sure that none
of this code is being compiled on ARM machine. The Windows build seems to
be unable to resolve the pg_comp_crc32c symbol, but it is not immediately
obvious to me why.
[0] https://cirrus-ci.com/task/6023394207989760
[1] https://cirrus-ci.com/task/5460444254568448
[2] https://cirrus-ci.com/task/6586344161411072
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2024-12-03 23:27:00 | Re: Doc: typo in config.sgml |
| Previous Message | Michael Paquier | 2024-12-03 22:41:19 | Re: Memory leak in WAL sender with pgoutput (v10~) |