Re: Fix 035_standby_logical_decoding.pl race conditions

Hi,

On Mon, Apr 07, 2025 at 03:16:07PM +0530, Amit Kapila wrote:
> On Thu, Apr 3, 2025 at 3:15 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > Hmm, but adding some additional smarts also makes this test less easy
> > to backpatch. I see your points related to the benefits, but I still
> > mildly prefer to go with the lesser changes approach for backbranches
> > patch. Normally, we don't enhance backbranches code without making
> > equivalent changes in HEAD, so adding some new bugs only in
> > backbranches has a lesser chance.
> >
>
> Bertrand, do you agree with the fewer changes approach (where active
> slots won't be tested) for backbranches? I think now that we have
> established that the vacuum full test is also prone to failure due to
> race condition in the test, this is the only remaining open point.

Yeah that's all good on my side, let's keep it that way and don't make the slot
active.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com