Re: [PATCH v1] parallel pg_restore: avoid disk seeks when jumping short distance forward

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Dimitrios Apostolou <jimis(at)gmx(dot)net>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PATCH v1] parallel pg_restore: avoid disk seeks when jumping short distance forward
Date: 2025-04-01 20:04:00
Message-ID: Z-xGsMvMgLYyPfjc@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 01, 2025 at 09:33:32PM +0200, Dimitrios Apostolou wrote:
> It didn't break any test, but I also don't see any difference, the
> performance boost is noticeable only when restoring a huge archive that is
> missing offsets.

This seems generally reasonable to me, but how did you decide on 1MB as the
threshold? Have you tested other values? Could the best threshold vary
based on the workload and hardware?

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Todd Cook 2025-04-01 20:12:29 Re: TEMP_CONFIG vs test_aio
Previous Message Andres Freund 2025-04-01 19:42:44 TEMP_CONFIG vs test_aio