| From: | Christoph Berg <myon(at)debian(dot)org> | 
|---|---|
| To: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> | 
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org | 
| Subject: | Re: pgsql: Add support for OAUTHBEARER SASL mechanism | 
| Date: | 2025-03-31 21:54:30 | 
| Message-ID: | Z-sPFl27Y0ZC-VBl@msg.df7cb.de | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers | 
> Add support for OAUTHBEARER SASL mechanism
Debian still has this experimental port with a GNU userland and a
FreeBSD kernel called kfreebsd. I don't expect anyone to particularly
care about it, but it found an actual bug:
/build/reproducible-path/postgresql-18-18~~devel.20250331/build/../src/interfaces/libpq/fe-auth-oauth-curl.c: In function ‘register_socket’:
/build/reproducible-path/postgresql-18-18~~devel.20250331/build/../src/interfaces/libpq/fe-auth-oauth-curl.c:1317:20: error: ‘actx’ undeclared (first use in this function); did you mean ‘ctx’?
 1317 |         actx_error(actx, "libpq does not support multiplexer sockets on this platform");
      |                    ^~~~
This should not be a compile-time error; actx is not defined outside
the #ifdef blocks there:
/*
 * Adds and removes sockets from the multiplexer set, as directed by the
 * libcurl multi handle.
 */
static int
register_socket(CURL *curl, curl_socket_t socket, int what, void *ctx,
                void *socketp)
{
#ifdef HAVE_SYS_EPOLL_H
    struct async_ctx *actx = ctx;
...
#endif
#ifdef HAVE_SYS_EVENT_H
    struct async_ctx *actx = ctx;
...
#endif
    actx_error(actx, "libpq does not support multiplexer sockets on this platform");
    return -1;
}
Christoph
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-03-31 22:06:54 | pgsql: Fix failing regression test on x86-32 machines | 
| Previous Message | Christoph Berg | 2025-03-31 20:40:31 | Re: pgsql: Add memory/disk usage for Window aggregate nodes in EXPLAIN. | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-03-31 22:02:22 | Periodic FSM vacuum doesn't happen in one-pass strategy vacuum. | 
| Previous Message | Heikki Linnakangas | 2025-03-31 21:31:43 | Re: CSN snapshots in hot standby |