| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com> |
| Cc: | "Chiranmoy(dot)Bhattacharya(at)fujitsu(dot)com" <Chiranmoy(dot)Bhattacharya(at)fujitsu(dot)com>, "Malladi, Rama" <ramamalladi(at)hotmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Ragesh(dot)Hajela(at)fujitsu(dot)com" <Ragesh(dot)Hajela(at)fujitsu(dot)com>, Salvatore Dipietro <dipiets(at)amazon(dot)com>, "Devanga(dot)Susmitha(at)fujitsu(dot)com" <Devanga(dot)Susmitha(at)fujitsu(dot)com> |
| Subject: | Re: [PATCH] SVE popcount support |
| Date: | 2025-03-28 21:22:17 |
| Message-ID: | Z-cTCc2cj73SfAsK@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Committed.
On Fri, Mar 28, 2025 at 10:25:26AM -0500, Nathan Bossart wrote:
> On Thu, Mar 27, 2025 at 03:31:27PM +0700, John Naylor wrote:
>> On Thu, Mar 27, 2025 at 10:38 AM Nathan Bossart
>> <nathandbossart(at)gmail(dot)com> wrote:
>>> I also noticed a silly mistake in 0003 that would cause us to potentially
>>> skip part of the tail. That should be fixed now.
>>
>> I'm not sure whether that meant it could return the wrong answer, or
>> just make more work for paths further down.
>> If the former, then our test coverage is not adequate.
>
> This one is my bad. I think the issue is that I'm writing this stuff on a
> machine that doesn't have SVE, so obviously my tests are happy as long as
> the Neon stuff is okay. We do have some tests in bit.sql that should in
> theory find this stuff. I'll be sure to verify all of this on a machine
> with SVE...
I verified that the tests failed without this fix on a machine with SVE.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2025-03-28 21:59:22 | Re: Adding skip scan (including MDAM style range skip scan) to nbtree |
| Previous Message | R, Rakshit | 2025-03-28 20:45:30 | Proposal for optimizations with simd enabled sort |