| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Lukas Fittl <lukas(at)fittl(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, ma lz <ma100(at)hotmail(dot)com> |
| Subject: | Re: query_id: jumble names of temp tables for better pg_stat_statement UX |
| Date: | 2025-03-26 00:34:02 |
| Message-ID: | Z-NLelZdH3GaLRNK@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
On Tue, Mar 25, 2025 at 07:24:20PM -0400, Tom Lane wrote:
> fails to honor $query_jumble_ignore as the other if-branches do.
> Perhaps it's unlikely that a node would have both query_jumble_custom
> and query_jumble_ignore annotations, but still, the script would emit
> completely incorrect code if it did. Also, the "# node type" comment
> should probably be moved down to within the first "elsif" block.
Oops, sorry about that. Fixed both of these in 27ee6ede6bc9.
> I'd change "semantically similar queries" to "otherwise-similar
> queries"; I think writing "semantically" will just confuse people.
If I get the difference right, semantically would apply to concepts
related to linguistics, but that's not what we have here, so you are
using a more general term.
Thanks for the suggestions.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Add-custom-query-jumble-function-for-RangeTblEntr.patch | text/x-diff | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-03-26 00:56:29 | Re: query_id: jumble names of temp tables for better pg_stat_statement UX |
| Previous Message | Tom Lane | 2025-03-25 23:24:20 | Re: query_id: jumble names of temp tables for better pg_stat_statement UX |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2025-03-26 00:43:28 | Re: AIO v2.5 |
| Previous Message | Noah Misch | 2025-03-26 00:19:15 | Re: AIO v2.5 |