| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: making relfilenodes 56 bits |
| Date: | 2022-09-30 00:12:56 |
| Message-ID: | YzY0iLxNbmaxHpbs@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 29, 2022 at 02:39:44PM -0400, Tom Lane wrote:
> The assertions in TupleDescInitEntry would have caught that,
> if only utils/misc/pg_controldata.c had more than zero test coverage.
> Seems like somebody ought to do something about that.
While passing by, I have noticed this thread. We don't really care
about the contents returned by these functions, and one simple trick
to check their execution is SELECT FROM. Like in the attached, for
example.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| controldata-regression.patch | text/x-diff | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-09-30 00:31:35 | Re: longfin and tamandua aren't too happy but I'm not sure why |
| Previous Message | Ranier Vilela | 2022-09-30 00:08:02 | Small miscellaneous fixes |