| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_upgrade test failure |
| Date: | 2022-09-20 01:25:41 |
| Message-ID: | YykWlaJj3dphGBvR@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Sep 19, 2022 at 06:13:17PM -0700, Andres Freund wrote:
> I don't really see what'd race with what here? pg_upgrade has precise control
> over what's happening here, no?
A code path could have forgotten a fclose() for example, but this code
is rather old and close-proof as far as I know. Most of the log files
are used with redirections for external calls, though I don't see
how these could still be hold after pg_upgrade finishes, though :/
Could the use meson somewhat influence when running tests on Windows?
> I've only seen it once so far, but there haven't been many CI runs of the
> meson branch since rebasing ontop of the last changes to pg_upgrade.
Hmm, okay. Is that a specific branch in one of your public repos?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-09-20 01:28:11 | pgsql: Split TESTDIR into TESTLOGDIR and TESTDATADIR |
| Previous Message | Andres Freund | 2022-09-20 01:18:06 | Re: pgsql: Fix createdb tests for C locale |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-09-20 01:31:22 | Re: pg_upgrade test failure |
| Previous Message | Tom Lane | 2022-09-20 01:23:08 | Re: Reducing the chunk header sizes on all memory context types |