Re: pgsql: Remove further unwanted linker flags from perl_embed_ldflags

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove further unwanted linker flags from perl_embed_ldflags
Date: 2022-09-02 11:18:21
Message-ID: YxHmfSiZquOAFobV@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Peter,

On Tue, Aug 23, 2022 at 02:29:49PM +0000, Peter Eisentraut wrote:
> Remove further unwanted linker flags from perl_embed_ldflags
>
> Remove the contents of $Config{ldflags} from ExtUtils::Embed's ldopts,
> like we already do with $Config{ccdlflags}. Those flags are the
> choices of those who built the Perl installation, which are not
> necessarily appropriate for building PostgreSQL. What we really want
> from ldopts are the options identifying the location and name of the
> libperl library, but unfortunately it doesn't appear possible to get
> that separately from the other stuff.
>
> The motivation for this was to strip -mmacosx-version-min options. We
> already did something similar for the -arch option. Both of those are
> now covered by this more general approach.
>
> Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
> Discussion: https://www.postgresql.org/message-id/flat/8c4fcb72-2574-ff7c-4c25-1f032d4a2a57%40enterprisedb.com

lorikeet (cygwin) has been failing for 9 days now on HEAD, while the
first failure happened here:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lorikeet&dt=2022-08-24%2000%3A11%3A00

This means that we have a problem for commits in the range of
c981879814~1..869e56a3. And in this range, it seems to me that this
commit is the primary suspect. Could you look at that?

Thanks,
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2022-09-02 11:26:21 pgsql: Doc: fix column list vs. replica identity rules.
Previous Message Michael Paquier 2022-09-02 07:58:32 pgsql: Expand the use of get_dirent_type(), shaving a few calls to stat