| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Niyas Sait <niyas(dot)sait(at)linaro(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add native windows on arm64 support |
| Date: | 2022-08-27 02:33:51 |
| Message-ID: | YwmCj/VGXjCeNcrh@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 25, 2022 at 08:29:43PM -0700, Andres Freund wrote:
> It's really not great that 7f3e17b4827 disabled randomization without even a
> comment as to why...
This story is on this thread, with some processes not able to start:
https://www.postgresql.org/message-id/BD0D89EC2438455C9DE0DC94D36912F4@maumau
> There actually seems to have been a lot of work in that area. See 617dc6d299c
> / bcbf2346d69 and as well as the retrying in 45e004fb4e39. Those weren't
> prevented by us disabling ASLR.
Indeed. 45e004f looks like the most interesting bit here. FWIW, I
would not mind re-enabling that on HEAD, as of something like the
attached. I have done a dozen of runs without seeing a test failure,
and knowing that we don't support anything older than Win10 makes me
feel safer about this change. Any objections?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Re-enable-ASLR-on-Windows.patch | text/x-diff | 973 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-08-27 03:00:44 | Re: Use array as object (src/fe_utils/parallel_slot.c) |
| Previous Message | John Naylor | 2022-08-27 02:32:45 | Re: windows cfbot failing: my_perl |