Re: Fix a comment in WalSnd structure

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix a comment in WalSnd structure
Date: 2022-08-22 00:22:52
Message-ID: YwLMXPMGmGc/J/5x@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 19, 2022 at 05:40:40PM +0530, Bharath Rupireddy wrote:
> WalSnd structure mutex is being used to protect all the variables of
> that structure, not just 'variables shown above' [1]. A tiny patch
> attached to fix the comment.

Yep, walsender.c tells the same story, aka that replyTime and latch
are updated with the spinlock taken. I'll go update the comment, and
you suggestion sounds fine to me.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2022-08-22 00:40:52 Re: Supporting TAP tests with MSVC and Windows
Previous Message Michael Paquier 2022-08-22 00:15:41 Re: Use array as object (src/fe_utils/parallel_slot.c)