Re: BUG #17349: Function gen_random_uuid duplicates in pgcrypto and core

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andreas Dijkman <andreas(dot)dijkman(at)cygnis(dot)nl>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #17349: Function gen_random_uuid duplicates in pgcrypto and core
Date: 2022-08-16 18:14:41
Message-ID: YvvekfZ7/UD2r6+Y@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Tue, Dec 28, 2021 at 08:36:22PM +0000, Andreas Dijkman wrote:
> Thanks for pointing me to the discussion. I’ve read the thread and would
> suggest applying the doc-note, that’s in the last part of that discussion:
>
>
> Small doc tweak suggestion - the pgcrypto docs [1] now say about
> gen_random_uuid():
>
> Returns a version 4 (random) UUID. (Obsolete, this function is now also
> included in core PostgreSQL.)
>
> which gives the impression the code contains two versions of this function,
> the core
> one and an obsolete one in pgcrypto. Per the commit message the situation
> is actually:
>
> The pgcrypto implementation now internally redirects to the built-in one.
>
> That would have avoided this bug-report I guess, as the documentation would
> reflect the actual situation better.

I have written the attached patch to clarify this.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Indecision is a decision. Inaction is an action. Mark Batterson

Attachment Content-Type Size
pgcrypto.diff text/x-diff 577 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Marcelo Marques 2022-08-16 20:39:59 Re: BUG #17588: RHEL 8 nothing provides libarmadillo.so.10 (64bit) needed by gdal-libs3x*
Previous Message Francisco Olarte 2022-08-16 16:08:14 Re: [PATCH] Fix segfault calling PQflush on invalid connection