Re: fix stale help message

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: fix stale help message
Date: 2022-08-14 10:16:57
Message-ID: YvjLmV9V1Xj2JI2i@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 10, 2022 at 11:32:18PM +0800, Junwang Zhao wrote:
> when parsing command-line options, the -f option support disabling
> 8 scan and join methods, o, b and t disable index-only scans,
> bitmap index scans, and TID scans respectively, add them to the
> help message.
>
> @@ -351,7 +351,7 @@ help(const char *progname)
> printf(_(" -?, --help show this help, then exit\n"));
>
> printf(_("\nDeveloper options:\n"));
> - printf(_(" -f s|i|n|m|h forbid use of some plan
> types\n"));
> + printf(_(" -f s|i|o|b|t|n|m|h forbid use of some plan
> types\n"));
> printf(_(" -n do not reinitialize shared
> memory after abnormal exit\n"));
> printf(_(" -O allow system table structure
> changes\n"));
> printf(_(" -P disable system indexes\n"));

set_plan_disabling_options() is telling that you have all of them, as
much as the docs. I don't mind fixing that as you suggest, FWIW.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Graaff, Selwyn 2022-08-14 10:29:01 latest patches not updated in repos
Previous Message Michael Paquier 2022-08-14 10:11:11 Re: Tab completion for "ALTER TYPE typename SET" and rearranged "Alter TYPE typename RENAME"