| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Make name optional in CREATE STATISTICS |
| Date: | 2022-07-23 05:43:52 |
| Message-ID: | YtuKmAr7DKn5w/MQ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 22, 2022 at 11:54:27PM -0400, Tom Lane wrote:
> That does not seem like an improvement. In v15:
>
> regression=# REINDEX SYSTEM CONCURRENTLY db;
> ERROR: cannot reindex system catalogs concurrently
>
> As of HEAD:
>
> regression=# REINDEX SYSTEM CONCURRENTLY db;
> ERROR: syntax error at or near "CONCURRENTLY"
> LINE 1: REINDEX SYSTEM CONCURRENTLY db;
> ^
>
> That is not a very helpful error, not even if the man page
> doesn't show the syntax as legal.
As the problem comes down to the fact that INDEX/TABLE, SCHEMA and
DATABASE/SYSTEM need to handle names for different object types each,
I think that we could do something like the attached, removing one
block on the way at the cost of an extra parser node.
By the way, it seems that 83011ce also broke the case of "REINDEX
DATABASE CONCURRENTLY", where the parser missed the addition of a
DefElem for "concurrently" in this case.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| reindex_syntax_tweak.patch | text/x-diff | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Malakhov | 2022-07-23 07:15:05 | Re: Pluggable toaster |
| Previous Message | Zhang Mingli | 2022-07-23 05:01:26 | Fix annotations nextFullXid |