| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Collect ObjectAddress for ATTACH DETACH PARTITION to use in event trigger |
| Date: | 2022-07-21 06:23:37 |
| Message-ID: | Ytjw6fYFo4/WMMnp@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 20, 2022 at 04:36:13PM +0530, Amit Kapila wrote:
> Right. But, I noticed that get_altertable_subcmdtypes() doesn't handle
> AT_AttachPartition or AT_DetachPartition. We can handle those and at
> least have a test for those in test_ddl_deparse\sql\slter_table.sql. I
> know it is not directly related to your patch but that way we will at
> least have some tests for Attach/Detach partition and in the future
> when we extend it to test ObjectAddresses of subcommands that would be
> handy. Feel free to write a separate patch for the same.
Yeah, that could be a separate patch. On top of that, what about
reworking get_altertable_subcmdtypes() so as it returns one row for
each CollectedCommand, as of (type text, address text)? We have
already getObjectDescription() to transform the ObjectAddress from the
collected command to a proper string.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-07-21 06:23:45 | Re: Memory leak fix in psql |
| Previous Message | Pavel Stehule | 2022-07-21 06:16:19 | Re: Schema variables - new implementation for Postgres 15 |