Re: CREATE TABLE AS, section IF NOT EXISTS should clarify what happens to the data

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: frank_limpert(at)yahoo(dot)com, Pg Docs <pgsql-docs(at)lists(dot)postgresql(dot)org>
Subject: Re: CREATE TABLE AS, section IF NOT EXISTS should clarify what happens to the data
Date: 2022-07-18 19:43:03
Message-ID: YtW3x4ERgS7J4Z2Y@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

fOn Thu, Jul 14, 2022 at 06:47:19PM -0700, David G. Johnston wrote:
> Not only is the existing table not modified, I think that the select query
> portion of the command is never even executed.  That would seem to be useful
> knowledge to have.
>
> Maybe something like:
>
> <para>
>  Do not throw an error if a relation with the same name already exists.
>  A notice is issued in this case.
>  If <literal>WITH DATA</literal> is specified (the default) the execution of
> the parsed query does not happen, leaving the existing table with its existing
> contents.
> </para>

I tried to go in that direction, but couldn't clearly name the
SELECT/VALUES part of the CREATE TABLE AS query because CREATE TABLE
AS is also a query. I felt trying to say we ran the CREATE TABLE AS
query but not the SELECT/VALUES of the query was just too confusing. I
used "simply issue a notice" as implying that nothing else happens,
which I considered sufficient.
>
> I've removed the xref to create table as there is nothing additional there of
> material benefit - the sentence:

Okay, removed. Updated patch attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Indecision is a decision. Inaction is an action. Mark Batterson

Attachment Content-Type Size
exists.diff text/x-diff 767 bytes

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Fujii Masao 2022-07-20 04:51:36 Re: list of flags that pg_settings_get_flags reports
Previous Message Michael Paquier 2022-07-16 02:46:11 Re: list of flags that pg_settings_get_flags reports