Re: Collect ObjectAddress for ATTACH DETACH PARTITION to use in event trigger

On Mon, Jul 25, 2022 at 09:25:07AM +0000, houzj(dot)fnst(at)fujitsu(dot)com wrote:
> BTW, while reviewing it, I found there are some more subcommands that the
> get_altertable_subcmdtypes() doesn't handle(e.g., ADD/DROP/SET IDENTITY and re ADD
> STAT). Shall we fix them all while on it ?
>
> Attach a minor patch to fix those which is based on the v2 patch set.

@@ -300,6 +300,18 @@ get_altertable_subcmdinfo(PG_FUNCTION_ARGS)
[ ... ]
default:
strtype = "unrecognized";
break;

Removing the "default" clause would help here as we would get compiler
warnings if there is anything missing. One way to do things is to set
strtype to NULL before going through the switch and have a failsafe as
some commands are internal so they may not be worth adding to the
output.
--
Michael