Re: doc: Move enum storage commentary to top of section

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: doc: Move enum storage commentary to top of section
Date: 2022-07-09 01:21:55
Message-ID: YsjYM70kgW3B2tXn@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 8, 2022 at 09:21:31PM -0400, Bruce Momjian wrote:
> On Wed, Jul 6, 2022 at 10:34:58AM -0700, David G. Johnston wrote:
> > Agreed.
> >
> > Tangentially: It does seem a bit unusual to call the fact that the values both
> > case-sensitive and limited to the length of a system identifier an
> > implementation detail.  But if anything the length is more of one than the
> > case-sensitivity.  Specifying NAMEDATALEN here seems like it breaks
> > encapsulation, it could refer by comparison to an identifier and only those
> > that care can learn how that length might be changed in a custom build of
> > PostgreSQL.
>
> I don't think we can do much to improve what we have already in the
> docs.

I have marked the commit-fest entry as returned with feedback.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Indecision is a decision. Inaction is an action. Mark Batterson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ibrar Ahmed 2022-07-09 01:27:04 Compilation issue on Solaris.
Previous Message Bruce Momjian 2022-07-09 01:21:31 Re: doc: Move enum storage commentary to top of section