psql --on-error-stop (Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still) commits after client-side error

From: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, robertmhaas(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: psql --on-error-stop (Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still) commits after client-side error
Date: 2022-06-15 09:13:56
Message-ID: Yqmi1IcXs5WofNvD@msg.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Re: Michael Paquier
> Well, done. One thing that I find a bit surprising in all that is the
> lack of consistency in the handling of the return code of psql when
> the last switch fails when not using ON_ERROR_STOP.

TBH ON_ERROR_STOP itself feels very brittle to me. Besides the fact
that `psql -vON_ERROR_STOP=1` looks very ugly, it's only one typo away
from breaking silently. `psql -vSTOP_ON_ERROR=1` (or -vON_EROR_STOP=1)
looks good as well, but doesn't work.

There should be a proper command line switch for it like
`psql --on-error-stop` since typoing that errors. (The short options
-eEsSq are already taken, so I'd propose psql -Q.)

Christoph
--
Senior Consultant, Tel.: +49 2166 9901 187
credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Geoff Richardson, Peter Lilley
Unser Umgang mit personenbezogenen Daten unterliegt folgenden
Bestimmungen: https://www.credativ.de/datenschutz

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Svante Richter 2022-06-15 12:16:14 COPY TO CSV produces data that is incompatible/unsafe for \COPY FROM CSV
Previous Message Michael Paquier 2022-06-15 06:09:53 Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still commits after client-side error