Re: pg_upgrade test writes to source directory

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_upgrade test writes to source directory
Date: 2022-06-03 03:29:04
Message-ID: YpmAAEvLqV0tbdzc@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 02, 2022 at 05:17:34PM -0400, Andrew Dunstan wrote:
> I hope we fix the original issue soon - it's apparently been the cause
> of numerous buildfarm failures that it was on my list to investigate
> e.g.
> <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2022-05-15%2019%3A24%3A27>

Oops. Thanks, Andrew, I was not aware of that. I don't really want
to wait more if this impacts some of the buildfarm animals. Even if
we don't conclude with the use of TESTOUTDIR for the time being, I see
no strong objections in using TESTDIR/tmp_check, aka
${PostgreSQL::Test::Utils::tmp_check}. So I propose to apply a fix
doing that in the next 24 hours or so. We can always switch to a
different path once we decide something else, if necessary.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2022-06-03 03:33:16 Re: some aspects of our qsort might not be ideal
Previous Message David Rowley 2022-06-03 03:13:43 Re: PG15 beta1 sort performance regression due to Generation context change