Re: [PATCH] Fix pg_upgrade test from v10

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Fix pg_upgrade test from v10
Date: 2022-06-02 04:48:56
Message-ID: YphBON83F/f0gG1x@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 02, 2022 at 12:36:30AM -0400, Tom Lane wrote:
> The buildfarm animals that test cross-version upgrades are not
> unhappy, so please be more specific about what problem you
> are trying to solve.

Anton is complaining about the case where you try to use the in-core
upgrade tests with a set of binaries/dump/source tree older that the
current version tested passed down as environment variables. test.sh
and the new TAP tests authorize that but they have their limits in
portability, which is what Anton is proposing to improve here. The
client buildfarm does not make use of the in-core facility, as it has
its own module and logic to check after the case of cross-version
upgrades (see PGBuild/Modules/TestUpgradeXversion.pm).

My 2c.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-06-02 05:09:58 Re: compiler warnings with gcc 4.8 and -Og
Previous Message Tom Lane 2022-06-02 04:36:30 Re: [PATCH] Fix pg_upgrade test from v10