Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
Date: 2022-05-10 00:57:29
Message-ID: Ynm4ecSwODdS23EA@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, May 09, 2022 at 10:10:27AM -0400, Andrew Dunstan wrote:
> The system() call should include redirection, since we only case about
> the return code.

Okay, done using File::Spec::devnull.

> I would just write this
>
> as
>
>     $ENV{$envname} = $envdefault if $rc == 0;
>
> There should be no need to set it to the empty string in case if
> failure, we already know it's undefined.

This needs to be adjusted on all the stable branches, so I'll do that
once this week's version is tagged. Attached is an updated patch for
now.
--
Michael

Attachment Content-Type Size
win32-vcregress-env-v2.patch text/x-diff 2.4 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-05-10 02:32:05 pgsql: Fix several issues with the TAP tests of pg_upgrade
Previous Message Tom Lane 2022-05-09 21:22:32 pgsql: Stamp 10.21.