Re: Correct comment in ProcedureCreate() for pgstat_create_function() call.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amul Sul <sulamul(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Correct comment in ProcedureCreate() for pgstat_create_function() call.
Date: 2022-05-13 07:09:00
Message-ID: Yn4EDN4ce27JIfn+@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 13, 2022 at 10:22:57AM +0530, Amul Sul wrote:
> Sorry, hit the send button too early :|

- /* ensure that stats are dropped if transaction commits */
+ /* ensure that stats are dropped if transaction aborts */
if (!is_update)
pgstat_create_function(retval);

As of what pgstat_create_function() does to create the stats of a new
function in a transactional way, it looks like you are right. Will
fix if there are no objections.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2022-05-13 08:08:53 Re: [PATCH] Compression dictionaries for JSONB
Previous Message Mikael Kjellström 2022-05-13 07:00:20 Re: recovery test failure on morepork with timestamp mystery