Re: Add missing MarkGUCPrefixReserved() in basebackup_to_shell module

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add missing MarkGUCPrefixReserved() in basebackup_to_shell module
Date: 2022-05-02 10:50:02
Message-ID: Ym+3WoxxW+L7YMcG@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 02, 2022 at 03:06:39PM +0530, Bharath Rupireddy wrote:
> It looks like commit c6306db24 (Add 'basebackup_to_shell' contrib
> module.) missed to reserve basebackup_to_shell module's custom GUC
> prefix via MarkGUCPrefixReserved("basebackup_to_shell");. This will
> remove
>
> Attaching a tiny patch to fix it.

You are obviously right. Will fix.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-05-02 10:55:10 Re: bogus: logical replication rows/cols combinations
Previous Message Michael Paquier 2022-05-02 10:48:18 Re: avoid multiple hard links to same WAL file after a crash