From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Daria Lepikhova <d(dot)lepikhova(at)postgrespro(dot)ru> |
Cc: | rjuju123(at)gmail(dot)com, exclusion(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Assert in pageinspect with NULL pages |
Date: | 2022-04-14 06:27:59 |
Message-ID: | Yle+73rLa/PHEHFx@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Mar 16, 2022 at 05:43:48PM +0900, Michael Paquier wrote:
> So, I have looked at this second part of the thread, and concluded
> that we should not fail for empty pages. First, we fetch pages from
> the buffer pool in normal mode, where empty pages are valid. There is
> also a second point in favor of doing so: code paths dedicated to hash
> indexes already do that, marking such pages as simply "unused". The
> proposal from Julien upthread sounds cleaner to me though in the long
> run, as NULL gives the user the possibility to do a full-table scan
> with simple clauses to filter out anything found as NULL.
It has been a couple of weeks, but I have been able to come back to
this set of issues for all-zero pages, double-checked the whole and
applied a set of fixes down to 10. So we should be completely done
here.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | John Naylor | 2022-04-14 06:36:01 | Re: Improving the "Routine Vacuuming" docs |
Previous Message | Yura Sokolov | 2022-04-14 05:58:33 | Re: BufferAlloc: don't take two simultaneous locks |