| From: | Mark Wong <markwkm(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Chapman Flack <chap(at)anastigmatix(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Konstantina Skovola <konskov(at)gmail(dot)com> |
| Subject: | Re: trigger example for plsample |
| Date: | 2022-04-08 17:34:00 |
| Message-ID: | YlByCLvap6LceaVq@g |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 07, 2022 at 06:29:53PM -0400, Tom Lane wrote:
> Chapman Flack <chap(at)anastigmatix(dot)net> writes:
> > v4 looks good to me.
>
> Pushed with very minor editorialization. Mainly, I undid the
> decision to stop printing the function source text, on the
> grounds that (1) it falsified the comment immediately above,
> and (2) if you have to print it anyway to avoid compiler warnings,
> you're just creating confusing inconsistency between the two
> handler functions.
Sounds good to me, thanks!
Regards,
Mark
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2022-04-08 18:57:53 | Re: Lowering the ever-growing heap->pd_lower |
| Previous Message | Nathan Bossart | 2022-04-08 17:05:19 | Re: avoid multiple hard links to same WAL file after a crash |