| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |
| Date: | 2022-03-31 07:56:36 |
| Message-ID: | YkVetIPIk1ScfC9Q@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 30, 2022 at 10:36:16PM -0700, Andres Freund wrote:
> On 2022-03-31 01:00:14 -0400, Tom Lane wrote:
> > How well does this patch work with pre-14 buildfarm clients?
>
> Looks to me like it'll just run the test twice, once via TestUpgrade, once via
> taptest. It's possible that there could be trouble somehow due to duplicated
> log files or something?
Hmm. TestUpgrade.pm also uses tmp_check/, and the TAP tests would
remove this path before running. Still, all the contents of the logs
would be printed out before moving to the next tests at the end of
check-pg_upgrade. It does not seem like this double run is going to
be an issue on this side.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-03-31 08:00:55 | Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work. |
| Previous Message | Dilip Kumar | 2022-03-31 07:52:24 | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |