| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | bharath(dot)rupireddyforpostgres(at)gmail(dot)com, masao(dot)fujii(at)oss(dot)nttdata(dot)com, nathandbossart(at)gmail(dot)com, sfrost(at)snowman(dot)net, bossartn(at)amazon(dot)com, rjuju123(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add checkpoint and redo LSN to LogCheckpointEnd log message |
| Date: | 2022-03-15 09:26:26 |
| Message-ID: | YjBbwiZSRsGzgbcW@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 15, 2022 at 05:23:40PM +0900, Kyotaro Horiguchi wrote:
> At Tue, 15 Mar 2022 12:19:47 +0530, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote in
>> On Fri, Mar 4, 2022 at 10:40 AM Kyotaro Horiguchi
>> <horikyota(dot)ntt(at)gmail(dot)com> wrote:
>> 0001 - I don't think you need to do this as UpdateControlFile
>> (update_controlfile) will anyway update it, no?
>> + /* Update control file using current time */
>> + ControlFile->time = (pg_time_t) time(NULL);
>
> Ugh.. Yes. It is a copy-pasto from older versions. They may have the
> same copy-pasto..
This thread has shifted to an entirely different discussion,
presenting patches that touch code paths unrelated to what was first
stated. Shouldn't you create a new thread with a proper $subject to
attract a more correct audience?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-03-15 09:30:31 | Re: pg_tablespace_location() failure with allow_in_place_tablespaces |
| Previous Message | Tomas Vondra | 2022-03-15 08:30:44 | Re: Column Filtering in Logical Replication |