| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_stat_get_replication_slot and pg_stat_get_subscription_worker incorrectly marked as proretset |
| Date: | 2022-02-22 02:45:44 |
| Message-ID: | YhROWPYHo9itaj5s@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 21, 2022 at 05:00:43PM +0530, Amit Kapila wrote:
> On Mon, Feb 21, 2022 at 4:56 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> That's the same thing as what I sent upthread, so that's correct to
>> me, except that I have fixed both functions :)
>
> Sorry, I hadn't looked at your patch.
That's fine. This is something you have committed, after all.
>> You are not touching pg_stat_get_subscription_worker() because the
>> plan is to revert it from HEAD? I have not followed the other
>> discussion closely.
>>
>
> It is still under discussion. I'll take the necessary action along
> with other things related to that view based on the conclusion on that
> thread.
Sounds good to me. The patch you are proposing upthread is OK for
me.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | kuroda.hayato@fujitsu.com | 2022-02-22 02:51:25 | RE: [Proposal] Add foreign-server health checks infrastructure |
| Previous Message | Michael Paquier | 2022-02-22 02:04:16 | Re: shared_preload_libraries = 'pg_stat_statements' failing with installcheck (compute_query_id = auto) |