| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Gunnar \"Nick\" Bluth" <gunnar(dot)bluth(at)pro-open(dot)de> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Alexander Kukushkin <cyberdemn(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, x4mmm(at)yandex-team(dot)ru, kondratovaleksey(at)gmail(dot)com |
| Subject: | Re: PATCH: add "--config-file=" option to pg_rewind |
| Date: | 2022-03-01 04:18:23 |
| Message-ID: | Yh2ej2/NuAXa6DyZ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 28, 2022 at 08:48:23PM +0100, Gunnar "Nick" Bluth wrote:
> So, how should we call the global "find the ***** 'postgres' executable and
> boil out if that fails" function?
> char postgres_exec_path[MAXPGPATH] = findPostgresExec();
> ?
That would mean only a couple of lines gained, and the readability
gained is minimal, so I'd be fine to keep the code as-is. I am not
sure about the full patch set yet, but the refactoring of the commands
to use PQExpBuffer is good by itself, so I have extracted this part of
the patch and applied that for now.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paul Jungwirth | 2022-03-01 04:31:55 | Re: range_agg with multirange inputs |
| Previous Message | Tom Lane | 2022-03-01 03:15:16 | Re: Allow root ownership of client certificate key |