| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add TAP test to automate the equivalent of check_guc |
| Date: | 2022-02-14 02:03:44 |
| Message-ID: | Ygm4gC4ZN3TU0Bqt@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Feb 12, 2022 at 05:31:55PM +0100, Christoph Berg wrote:
> To support multiple major versions in parallel, we need
> /usr/lib/postgresql/NN/lib and /usr/share/postgresql/NN, so it's not a
> single $PREFIX. But you are correct, and ./configure supports that.
Yep, I don't quite see the problem, but I don't have the years of
experience in terms of packaging you have, either. (NB: I use various
--libdir and --bindir combinations that for some of packaging of PG I
maintain for pg_upgrade, but that's not as complex as Debian, I
guess).
> I was confusing that with this: The problem that led to the pg_config
> patch years ago was that we have a /usr/bin/pg_config in
> (non-major-version-dependant) libpq-dev, and
> /usr/lib/postgresql/NN/bin/pg_config in the individual
> postgresql-server-dev-NN packages, and iirc the /usr/bin version
> didn't particularly like the other binaries being in
> /usr/lib/postgresql/NN/bin/.
>
> I guess it's time to revisit that problem now and see if it can be
> solved more pretty today on our side.
If you can solve that, my take is that it could make things nicer in
the long-run for some of the TAP test facilities. Still, I'll try to
look at a solution for this thread that does not interact badly with
what you are doing, and I am going to grab your patch when testing
things.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2022-02-14 02:08:15 | pgsql: Correct Makefile dependencies for catalog scripts |
| Previous Message | Michael Paquier | 2022-02-14 01:53:04 | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-02-14 02:07:19 | Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c) |
| Previous Message | Michael Paquier | 2022-02-14 01:53:04 | Re: pgsql: Add suport for server-side LZ4 base backup compression. |