| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, gkokolatos(at)pm(dot)me, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Plug minor memleak in pg_dump |
| Date: | 2022-02-09 02:56:46 |
| Message-ID: | YgMtbuZEeX4gzXqK@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 02, 2022 at 10:06:13AM +0100, Daniel Gustafsson wrote:
> The leak itself is clearly not something to worry about wrt memory pressure.
> We do read into tmp and free it in other places in the same function though (as
> you note above), so for code consistency alone this is worth doing IMO (and it
> reduces the risk of static analyzers flagging this).
>
> Unless objected to I will go ahead with getting this committed.
Looks like you forgot to apply that?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-02-09 03:04:51 | Re: [PATCH] Add min() and max() aggregate functions for xid8 |
| Previous Message | Kyotaro Horiguchi | 2022-02-09 02:52:04 | Re: Add checkpoint and redo LSN to LogCheckpointEnd log message |