| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2022-01-26 01:29:29 |
| Message-ID: | YfCj+QFS6hKlcscJ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 25, 2022 at 09:52:12PM +0530, tushar wrote:
> C) -R option is silently ignoring
>
> go to /tmp/pp folder and extract it - there is no "standby.signal" file and
> if we start cluster against this data directory,it will not be in slave
> mode.
Yeah, I don't think it's good to silently ignore the option, and we
should not generate the file on the server-side. Rather than erroring
in this case, you'd better add the file to the existing compressed
file of the base data folder on the client-side.
This makes me wonder whether we should begin tracking any open items
for v15.. We don't want to lose track of any issue with features
committed already in the tree.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2022-01-26 01:42:36 | RE: row filtering for logical replication |
| Previous Message | Michael Paquier | 2022-01-26 01:23:46 | Re: refactoring basebackup.c |