Re: pgsql: tests: Consistently use pg_basebackup -cfast --no-sync to accele

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: tests: Consistently use pg_basebackup -cfast --no-sync to accele
Date: 2022-01-18 01:18:36
Message-ID: YeYVbHXaNfW9kavH@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Andres,

On Mon, Jan 17, 2022 at 11:48:02PM +0000, Andres Freund wrote:
> tests: Consistently use pg_basebackup -cfast --no-sync to accelerate tests.
>
> Most tests invoking pg_basebackup themselves did not yet use -cfast, which
> makes pg_basebackup take considerably longer. The only reason this didn't
> cause the tests to take many minutes is that spread checkpoints only throttle
> when writing out a buffer and there aren't that many dirty buffers in the
> tests...

Are you planning to back-patch any of this? It seems to me that it
would not hurt, and making the tests faster on back-branches saves
time when working on those branches.

Thanks,
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-01-18 01:28:08 Re: pgsql: tests: Consistently use pg_basebackup -cfast --no-sync to accele
Previous Message Andres Freund 2022-01-17 23:48:02 pgsql: tests: Consistently use pg_basebackup -cfast --no-sync to accele