| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Improve error handling of HMAC computations and SCRAM |
| Date: | 2022-01-12 03:56:17 |
| Message-ID: | Yd5RYX89Qy6Okv8u@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 11, 2022 at 11:08:59AM +0300, Sergey Shinderuk wrote:
> Yeah, that's better. I thought "providing errors about an error" was a
> typo, but now I see the same comment was committed in b69aba745. Is it just
> me? :)
It is not only you :) I have applied a fix to fix the comments on
HEAD and REL_14_STABLE.
Attached is a rebased patch for the HMAC portions, with a couple of
fixes I noticed while going through this stuff again (mostly around
SASLprep and pg_fe_scram_build_secret), and a fix for a conflict
coming from 9cb5518. psql's \password is wrong to assume that the
only error that can happen for scran-sha-256 is an OOM, but we'll get
there.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-01-12 03:59:54 | Re: pg_upgrade should truncate/remove its logs before running |
| Previous Message | Amit Kapila | 2022-01-12 03:21:24 | Re: Skipping logical replication transactions on subscriber side |